Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Apply jasypt hoho #9

Merged
merged 4 commits into from
Jun 23, 2024
Merged

feat: Apply jasypt hoho #9

merged 4 commits into from
Jun 23, 2024

Conversation

god9599
Copy link
Member

@god9599 god9599 commented Jun 23, 2024

πŸ›  Changes

πŸ§šβ€β™€οΈ To Reviewers

πŸŽ’ Related Issues (optional)

πŸ‘” Check List

  • PR 이름이 맞게 μž‘μ„±λ˜μ—ˆλŠ”κ°€? (ex. feat: User login ~)
  • Testκ°€ μ„±κ³΅μ μœΌλ‘œ μ‹€ν–‰λ˜λŠ”κ°€?

@Test
fun execute() {
stringEncryptor.encrypt(plainText).let { encrypted ->
println(encrypted)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: μ„ μƒλ‹˜ μ—¬κΈ° println μžˆμ–΄μš”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μš”κ±° λ‹€λ₯Έ μ•”ν˜Έν™” ν•  λ³€μˆ˜ 있으면 이 ν…ŒμŠ€νŠΈ μ½”λ“œ μ¨μ„œ ν•˜λΌλŠ” 의미둜 둜그 찍히게 ν•΄λ‘” 것!

@210-reverof 210-reverof changed the title apply jasypt hoho feat: Apply jasypt hoho Jun 23, 2024
build.gradle.kts Outdated
@@ -29,7 +29,9 @@ subprojects {
dependencies {
implementation("org.springframework.boot:spring-boot-starter")
implementation("org.jetbrains.kotlin:kotlin-reflect")
implementation("com.github.ulisesbocchio:jasypt-spring-boot-starter:3.0.5")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버전 λ”°λ‘œ 빼도 쒋을 것 κ°™μ•„μš©

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸƒπŸΌβ€β™‚οΈ

@god9599 god9599 merged commit 5894272 into develop Jun 23, 2024
2 checks passed
@god9599 god9599 deleted the feature/jasypt branch June 23, 2024 13:31
210-reverof pushed a commit that referenced this pull request Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants