feat: Create event #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbeomgeun
reviewed
Jul 28, 2024
pic-api/src/main/kotlin/com/mashup/pic/event/controller/EventController.kt
Outdated
Show resolved
Hide resolved
bbeomgeun
reviewed
Jul 28, 2024
pic-api/src/main/kotlin/com/mashup/pic/event/controller/dto/CreateEventRequest.kt
Show resolved
Hide resolved
bbeomgeun
reviewed
Jul 28, 2024
pic-domain/src/main/kotlin/com/mashup/pic/domain/event/EventService.kt
Outdated
Show resolved
Hide resolved
mkSpace
requested changes
Jul 28, 2024
pic-api/src/main/kotlin/com/mashup/pic/event/controller/dto/CreateEventRequest.kt
Outdated
Show resolved
Hide resolved
| return groupRepository.findByIdOrNull(groupId) | ||
| ?: throw PicException.of( | ||
| type = PicExceptionType.NOT_EXIST, | ||
| message = "$groupId μ ν΄λΉνλ κ·Έλ£Ήλ₯Ό μ°Ύμ μ μμ΅λλ€." |
There was a problem hiding this comment.
Suggested change
| message = "$groupId μ ν΄λΉνλ κ·Έλ£Ήλ₯Ό μ°Ύμ μ μμ΅λλ€." | |
| message = "$groupId μ ν΄λΉνλ κ·Έλ£Ήμ μ°Ύμ μ μμ΅λλ€." |
| description: String, | ||
| date: LocalDateTime, | ||
| pictures: List<String> | ||
| ): Long { |
There was a problem hiding this comment.
idλ§ λ°ννλ μ΄μ κ° μλμ?
There was a problem hiding this comment.
νλ‘μ°μ idλ‘ μμΈλ³΄κΈ° api νΈμΆ μμ μ΄κΈ° λλ¬Έμ λλΉ
Comment on lines
+15
to
+17
| private val eventRepository: EventRepository, | ||
| private val groupRepository: GroupRepository, | ||
| private val eventJoinRepository: EventJoinRepository |
There was a problem hiding this comment.
λ°λ‘ λλμ§ μμΌμ ¨λ€μ?
There was a problem hiding this comment.
μ ꡬ체μ μΌλ‘ μ΄λ»κ² λλλ κ±Έ λ§μνμλμ§ μ κ° μ΄ν΄λͺ»ν κ² κ°μμ
bbeomgeun
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Changes
π§ββοΈ To Reviewers
π Related Issues (optional)
π Check List