feat: 카카오 로그인 구현 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkSpace
reviewed
Jun 9, 2024
pic-api/src/main/kotlin/com/mashup/pic/auth/applicationService/AuthApplicationService.kt
Outdated
Show resolved
Hide resolved
pic-api/src/main/kotlin/com/mashup/pic/auth/applicationService/dto/LoginServiceResponse.kt
Outdated
Show resolved
Hide resolved
pic-api/src/main/kotlin/com/mashup/pic/auth/controller/AuthController.kt
Outdated
Show resolved
Hide resolved
pic-api/src/main/kotlin/com/mashup/pic/auth/controller/dto/LoginResponse.kt
Show resolved
Hide resolved
pic-domain/src/main/kotlin/com/mashup/pic/domain/user/UserService.kt
Outdated
Show resolved
Hide resolved
pic-external/src/main/kotlin/com/mashup/pic/external/kakao/KakaoClient.kt
Outdated
Show resolved
Hide resolved
pic-external/src/main/kotlin/com/mashup/pic/external/kakao/KakaoClient.kt
Outdated
Show resolved
Hide resolved
|
LGTM |
god9599
reviewed
Jun 10, 2024
pic-api/src/main/kotlin/com/mashup/pic/auth/applicationService/dto/LoginServiceRequest.kt
Outdated
Show resolved
Hide resolved
god9599
reviewed
Jun 10, 2024
pic-api/src/main/kotlin/com/mashup/pic/auth/controller/AuthController.kt
Outdated
Show resolved
Hide resolved
mkSpace
reviewed
Jun 12, 2024
pic-external/src/main/kotlin/com/mashup/pic/external/kakao/KakaoClient.kt
Outdated
Show resolved
Hide resolved
pic-api/src/main/kotlin/com/mashup/pic/security/jwt/JwtTokenUtil.kt
Outdated
Show resolved
Hide resolved
god9599
reviewed
Jun 13, 2024
pic-api/src/main/kotlin/com/mashup/pic/auth/controller/dto/LoginRequest.kt
Outdated
Show resolved
Hide resolved
210-reverof
force-pushed
the
feature/login
branch
from
f67c7d3
to
a53ad3e
Compare
mkSpace
reviewed
Jun 14, 2024
pic-api/src/main/kotlin/com/mashup/pic/config/SecurityConfig.kt
Outdated
Show resolved
Hide resolved
pic-api/src/main/kotlin/com/mashup/pic/security/handler/HttpStatusAccessDeniedHandler.kt
Show resolved
Hide resolved
pic-api/src/main/kotlin/com/mashup/pic/security/jwt/JwtTokenFilter.kt
Outdated
Show resolved
Hide resolved
mkSpace
reviewed
Jun 14, 2024
pic-api/src/main/kotlin/com/mashup/pic/security/jwt/JwtTokenFilter.kt
Outdated
Show resolved
Hide resolved
pic-api/src/main/kotlin/com/mashup/pic/security/jwt/JwtTokenUtil.kt
Outdated
Show resolved
Hide resolved
pic-api/src/main/kotlin/com/mashup/pic/security/oidc/KakaoIdTokenValidator.kt
Show resolved
Hide resolved
pic-api/src/main/kotlin/com/mashup/pic/security/oidc/KakaoIdTokenValidator.kt
Outdated
Show resolved
Hide resolved
pic-external/src/main/kotlin/com/mashup/pic/external/config/RestClientConfig.kt
Outdated
Show resolved
Hide resolved
pic-external/src/main/kotlin/com/mashup/pic/external/kakao/KakaoJwksClient.kt
Outdated
Show resolved
Hide resolved
god9599
approved these changes
Jun 14, 2024
|
@bbeomgeun 님, 리뷰 왜 안해주세요 ㅡㅡ+ |
|
@KimDoubleB 아니 재민이 리뷰봐바 형 리뷰할게없어;; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경 사항
To Reviewers
Android, iOS 로그인 담당자와 합의해서 아래 그림 로직으로 결정했습니다 (참고)TODO