Merge pull request #71 from mash-up-kr/fix/index-error

�fix: Fix index error
mash-up-kr · Aug 19, 2024 · fb896c4 · fb896c4
2 parents c78a613 + bc85d9b
commit fb896c4
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pic-api/src/main/kotlin/com/mashup/pic/event/controller/dto/UploadImageRequest.kt b/pic-api/src/main/kotlin/com/mashup/pic/event/controller/dto/UploadImageRequest.kt
@@ -1,10 +1,12 @@
 package com.mashup.pic.event.controller.dto
 
 import com.mashup.pic.event.applicationService.dto.UploadImageServiceRequest
+import jakarta.validation.constraints.NotNull
+import jakarta.validation.constraints.Size
 
 data class UploadImageRequest(
-    val eventId: Long,
-    val imageUrls: List<String>
+    @field:NotNull val eventId: Long,
+    @field:Size(min = 1) val imageUrls: List<String>
 )
 
 fun UploadImageRequest.toServiceRequest(userId: Long): UploadImageServiceRequest = UploadImageServiceRequest(userId, eventId, imageUrls)
diff --git a/pic-api/src/main/kotlin/com/mashup/pic/vote/applicationservice/VoteApplicationService.kt b/pic-api/src/main/kotlin/com/mashup/pic/vote/applicationservice/VoteApplicationService.kt
@@ -34,8 +34,8 @@ class VoteApplicationService(
         voteService.markVoted(request.userId, request.eventId)
 
         if (voteService.hasEveryoneVoted(request.eventId)) {
+            resultService.generateResult(request.eventId)
             eventService.endEventVoting(request.eventId)
-            resultService.generateResult(10)
         }
 
         val randomImageUrl = voteService.getVotedRandomImageUrl(request.userId, request.eventId)