Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] 그룹 생성 시 사진 업로드 동안 인디케이터 노출 #156

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Hotfix] 그룹 생성 시 사진 업로드 동안 인디케이터 노출 #156

wants to merge 1 commit into from
+25 −0

Conversation

serena0720
Copy link
Collaborator

📌 Related Issue

🚀 Description

  • 그룹 생성 시 그룹 대표 사진 업로드 동안 인디케이터 뷰 노출

✅ Done

  • SelectGroupPhotoCore, View 수정

📸 Screenshot

Sep-22-2024 01-07-51

@serena0720 serena0720 added the Hotfix 🚨 label Sep 21, 2024
GREENOVER
GREENOVER approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@GREENOVER GREENOVER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

짝짝짝~~

Projects/Features/Scene/CreateGroupScene/SelectGroupPhoto/SelectGroupPhotoCore.swift
@@ -78,6 +82,7 @@ public struct SelectGroupPhotoCore {
Reduce { state, action in
switch action {
case .nextButtonTapped:
state.isLoading = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setIsLoading 액션을 활용하면 어떤가요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GREENOVER GREENOVER GREENOVER approved these changes

@hope1053 hope1053 Awaiting requested review from hope1053

@zekexros zekexros Awaiting requested review from zekexros

Assignees

@serena0720 serena0720

Labels
Hotfix 🚨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serena0720 @GREENOVER