Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: edit visibility of map #137

Merged
merged 2 commits into from
Sep 22, 2024
Merged

feat: edit visibility of map #137

merged 2 commits into from
Sep 22, 2024

Conversation

poiu694
Copy link
Member

@poiu694 poiu694 commented Sep 21, 2024

Issue Number

image image

Description

구현 내용 및 작업한 내용

  • 작업 내역 1
  • 작업 내역 2

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 전달 사항 1
  • 전달 사항 2

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

Copy link

The latest updates on your projects. Preview: https://vitamin-c-de1kvmy2v-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-09-21T08:10:16Z

Copy link
Member

@hee-suh hee-suh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번 주말 오픈런은 나의 것...

name,
})
revalidate(['map', mapInfo.id])
notify.success(`${mapNameInput} 지도를 ${isPublic ? '공개' : '비공개'}로 바꾸었습니다.`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기 mapNameInput -> mapInfo.name !

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완완

}
}

const fetchRevalMap = async (isPublic: boolean) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reval?! reveal인가요? updateMapVisibility는 어떨까용

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완완

@poiu694 poiu694 changed the title feat: map reveal edit feat: edit visibility of map Sep 22, 2024
Copy link

The latest updates on your projects. Preview: https://vitamin-c-qk6rwv277-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-09-22T11:41:14Z

@poiu694 poiu694 merged commit cecafc9 into main Sep 22, 2024
3 checks passed
@poiu694 poiu694 deleted the feature/map-public branch September 22, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants