Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: infinite scroll just working on frontend bottomsheet #136

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

poiu694
Copy link
Member

@poiu694 poiu694 commented Sep 21, 2024

Issue Number

Description

구현 내용 및 작업한 내용

  • 작업 내역 1
  • 작업 내역 2

To Reviewers

PR을 볼 때 주의깊게 봐야하거나 말하고 싶은 점

  • 전달 사항 1
  • 전달 사항 2

Checklist

PR 등록 전 확인한 것

  • 올바른 타켓 브랜치를 설정하였는가
  • PR 제목은 포맷과 내용 둘 다 알맞게 작성되었는가 (e.g., feat: add login page)
  • Description에 PR을 구체적으로 설명했는가

@poiu694 poiu694 changed the title feat: infinite scroll just working on frontend in bottomsheet feat: infinite scroll just working on bottomsheet in frontend Sep 21, 2024
@poiu694 poiu694 changed the title feat: infinite scroll just working on bottomsheet in frontend feat: infinite scroll just working on frontend bottomsheet Sep 21, 2024
Copy link

The latest updates on your projects. Preview: https://vitamin-c-dwckf0p77-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-09-21T07:44:54Z

Copy link

The latest updates on your projects. Preview: https://vitamin-c-mtyc24slt-poiu694s-projects.vercel.app

Name Status Preview Updated
VitaminC_Web ✅ Ready Visit Preview 2024-09-21T07:45:42Z

Copy link
Member

@hee-suh hee-suh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

데이터 지킴이!!

@@ -50,7 +50,7 @@ const PlaceListItem = ({
<ProxyImage
key={`${placeId}-${image}-${index}`}
src={image}
className="aspect-square w-[calc(33.4%-8px)] rounded-md object-cover"
className="aspect-square w-[calc(33.4%-8px)] min-w-[calc(33.4%-8px)] rounded-md object-cover"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 min 감쟈!

@poiu694 poiu694 merged commit 0d1e3ff into main Sep 22, 2024
3 checks passed
@poiu694 poiu694 deleted the feature/infinite-scroll branch September 22, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants