Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat; pick 을 생성하면 pick 대상에게 알림을 보내요. (SSE기반) #90

Merged
merged 4 commits into from
Aug 16, 2024
Merged

feat; pick 을 생성하면 pick 대상에게 알림을 보내요. (SSE기반) #90

merged 4 commits into from
Aug 16, 2024

Conversation

yaeoni
Copy link
Collaborator

@yaeoni yaeoni commented Aug 15, 2024 •
edited
Loading

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [add] pr template
  • 🧹 불필요한 코드는 제거했나요?

작업 내용

  • SSE 를 이용해 알림을 보내고자해요.
  • 우선 pick이 생성되면 pick 대상자에게 event를 발송하는 것부터 시작해요.

비고 (첨부자료)

  • create pick 을 직접 호출하려했는데 지금 디비 상 데이터가 따로 없어서 우선 테스트용 api로 테스트했어욘

@yaeoni yaeoni self-assigned this Aug 15, 2024
yaeoni
yaeoni commented Aug 15, 2024
View reviewed changes
Copy link
Collaborator Author

@yaeoni yaeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

로컬에선 테스트 완료~

build.gradle.kts Show resolved Hide resolved
service/src/main/kotlin/com/mashup/dojo/service/NotificationService.kt Show resolved Hide resolved
xonmin
xonmin approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@xonmin xonmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요 우선 기능 구현 먼저 고고링

service/src/main/kotlin/com/mashup/dojo/service/NotificationService.kt Show resolved Hide resolved
@yaeoni yaeoni merged commit aec1738 into master Aug 16, 2024
1 check passed
@yaeoni yaeoni deleted the yaeoni/pick-notification branch August 16, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xonmin xonmin xonmin approved these changes

@wonlog-g wonlog-g Awaiting requested review from wonlog-g wonlog-g is a code owner

@toychip toychip Awaiting requested review from toychip toychip is a code owner

Assignees

@yaeoni yaeoni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaeoni @xonmin