Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add endTime in Qset #84

Merged
merged 2 commits into from
Aug 10, 2024
Merged

add endTime in Qset #84

merged 2 commits into from
Aug 10, 2024

Conversation

xonmin
Copy link
Member

@xonmin xonmin commented Aug 10, 2024

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”? e.g. [add] pr template
  • 🧹 λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?

μž‘μ—… λ‚΄μš©

  • QSet 내에 PickTime 의 (publish / end At) 정보λ₯Ό 가지고 μžˆλ„λ‘ λ³€κ²½ν•©λ‹ˆλ‹€.
  • λ”°λΌμ„œ QSet 을 λ§Œλ“€ λ–„λŠ” λ§ˆμ§€λ§‰ 이전 endAt 을 publishAt νƒ€μž„μœΌλ‘œ κ°€μ§€κ²Œ λ©λ‹ˆλ‹€.

λΉ„κ³  (μ²¨λΆ€μžλ£Œ)

@xonmin xonmin self-assigned this Aug 10, 2024
toychip
toychip approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@toychip toychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ‘

@xonmin xonmin merged commit 1d79435 into master Aug 10, 2024
1 check passed
@xonmin xonmin deleted the xonmin/add-endat-Qset branch August 10, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toychip toychip toychip approved these changes

@wonlog-g wonlog-g Awaiting requested review from wonlog-g wonlog-g is a code owner

@yaeoni yaeoni Awaiting requested review from yaeoni yaeoni is a code owner

Assignees

@xonmin xonmin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xonmin @toychip