-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: 픽 스킵 기능 추가 #137
base: master
Are you sure you want to change the base?
add: 픽 스킵 기능 추가 #137
Conversation
questionId = question.id, | ||
questionSetId = questionSet.id, | ||
questionSheetId = command.questionSheetId, | ||
pickerMemberId = command.pickerId, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 pickerId도 더미값으로 넣으면 어떨까요?
SKIP + pickerId 이런식으로 저장해도 좋을 것 같아요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pickerId 가 더미로 저장되면
Dojo-Spring/service/src/main/kotlin/com/mashup/dojo/usecase/QuestionUseCase.kt
Lines 170 to 172 in c4bdda4
val solvedQuestionIds = | |
pickService.getSolvedPickList(memberId, operatingQSet.id) | |
.map { it.questionId } |
해당 부분에서 이미 푼 문제 조회가 어려워 필터링 부분도 변경되어야 합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
더미값으로 넣는 이유가 따로 있을까요??
스킵도 하나의 pick으로 저장되고 있어 pickerId는 기존 memberId 넣어도 괜찮다고 생각했어요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 그러네요. 다른곳에서 추가적으로 필터링을 안하기 위해 더미값 넣으면 어떨까 했었는데, 그럼 그대로 가는 게 좋을 것 같네요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
override fun getQuestionSheetList(memberId: MemberId): QuestionUseCase.GetQuestionSheetsResult { |
해당 부분도 로직 skip 한 문제 필터하도록 변경해주는 부분 추가해줘야 할 것 같아요
getQuestionSheetList의 경우 안 푼 문제들 반환하는 로직으로 스킵한 질문 필터링은 필요하지 않을 것 같습니다! |
[add] pr template
작업 내용
특정 상대를 픽하지 않고 질문을 스킵하는 기능입니다.
비고 (첨부자료)