Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 친구 해제 API를 작성해요. #135

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Conversation

yaeoni
Copy link
Collaborator

@yaeoni yaeoni commented Sep 21, 2024

  • 🔀 PR 제목의 형식을 잘 작성했나요? e.g. [add] pr template
  • 🧹 불필요한 코드는 제거했나요?

작업 내용

친구 해제 API 를 작성해요.
친구 추가 API와 비슷한 형태로 만들었어요!

Copy link
Member

@toychip toychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fromMemberId를 클라이언트로부터 받지 않고 토큰에서 추출하면 어떨까요~~
누군가 마음 먹는다면 특정 사용자 친구 삭제 다 가능할 것 같아요

): DojoApiResponse<Unit> {
val command =
MemberUseCase.UpdateFriendCommand(
fromId = request.fromMemberId,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fromId는 MemberPrincipalContextHolder.current().id요렇게 꺼내는 건 어떨까요~?

@toychip toychip merged commit ee75998 into master Sep 24, 2024
1 check passed
@toychip toychip deleted the yaeoni/un-follow-friend branch September 24, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants