Skip to content

feature: add gift domain #27

feature: add gift domain

feature: add gift domain #27

Triggered via push December 18, 2023 02:39
Status Success
Total duration 50s
Artifacts
PHP Insights checks
40s
PHP Insights checks
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
PHP Insights checks: src/Domain/Quotes/States/Banned.php#L7
* [Forbidden public property] Do not use public properties. Use method access instead.
PHP Insights checks: src/Domain/Quotes/States/Banned.php#L1
* [Declare strict types] Missing declare(strict_types=1). * [Normal classes are forbidden. Classes must be final or abstract]
PHP Insights checks: src/Domain/Quotes/States/Drafted.php#L7
* [Forbidden public property] Do not use public properties. Use method access instead.
PHP Insights checks: src/Domain/Quotes/States/Drafted.php#L1
* [Declare strict types] Missing declare(strict_types=1). * [Normal classes are forbidden. Classes must be final or abstract]
PHP Insights checks: src/Domain/Quotes/States/Published.php#L7
* [Forbidden public property] Do not use public properties. Use method access instead.
PHP Insights checks: src/Domain/Quotes/States/Published.php#L1
* [Declare strict types] Missing declare(strict_types=1). * [Normal classes are forbidden. Classes must be final or abstract]
PHP Insights checks: src/Domain/Quotes/States/QuoteState.php#L11
* [Forbidden public property] Do not use public properties. Use method access instead.
PHP Insights checks: src/Domain/Quotes/States/QuoteState.php#L1
* [Declare strict types] Missing declare(strict_types=1).
PHP Insights checks: src/Domain/Quotes/States/QuoteState.php#L18
* [Todo] Comment refers to a TODO task "Implement better logic in index quotes, authorization, how a quote becomes banned" * [Line length] Line exceeds 80 characters; contains 97 characters
PHP Insights checks: src/Domain/Rating/Models/Rating.php#L28
* [Forbidden public property] Do not use public properties. Use method access instead. * [Property type hint] Property \Domain\Rating\Models\Rating::$incrementing does not have native type hint nor @var annotation for its value.
PHP Insights checks
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/