Act as a thumbfast provider #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the patched OSC is renamed to
thumbfast.lua, it will expose a thumbfast-compatible API. The script returns and doesn't act as an OSC.This allows the thumbnailer to work with any UIs that implement this less invasive API: https://github.com/po5/thumbfast#ui-support
Positioning and decorations are left up to each client script.
Renaming is required as all scripts use
script-message-to thumbfast, which mpv forwards only to the specified script.Of course it still works in its normal non-thumbfast mode.
Closes #1
Hoping this will spark renewed interest and we can implement each other's fixes to improve thumbnails.
I am the maintainer of thumbfast, if that wasn't obvious.