solving out of boundaries vulnerability

marwanelmessiry · Jan 13, 2025 · 5a2a2fb · 5a2a2fb
1 parent 4ff8153
commit 5a2a2fb
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/fpmsyncd/routesync.cpp b/fpmsyncd/routesync.cpp
@@ -2150,11 +2150,15 @@ string RouteSync::getNextHopIf(struct rtnl_route *route_obj)
         char if_name[IFNAMSIZ] = "0";
 
         /* If we cannot get the interface name */
-        if (!getIfName(if_index, if_name, IFNAMSIZ))
+       if (!getIfName(if_index, if_name, IFNAMSIZ))
         {
-            strcpy(if_name, "unknown");
+              strncpy(if_name, "unknown", IFNAMSIZ - 1); // replacing the strcpy with the strncpy to ensure that the copied string will not exceed the size
+              if_name[IFNAMSIZ - 1] = '\0'; // Enssuring last element in the string is NULL character 
+
+
         }
 
+
         result += if_name;
 
         if (i + 1 < rtnl_route_get_nnexthops(route_obj))