Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client tests and improve memory handling in tests #20

Merged
merged 29 commits into from
Jun 13, 2024
Merged

Conversation

thomvet
Copy link
Collaborator

@thomvet thomvet commented Apr 29, 2024

This PR contains the following high level points:

  • introduces tests for non-async client read, client write and client service calls.
  • remove generation code for UA_Client_readXXXAttribute_async functions from client.jl (these are not inlined, hence contained in open62541.jl directly, also evidenced from empty attributes_UA_Client_read_async variable in generated_defs.jl)
  • improve memory handling within testsets in general
  • removes auto-generated docstrings from open62541.jl
  • complete docstrings within client.jl
  • transfer remaining high level functions to highlevel_client.jl
  • restructure async functions in client.jl
  • added additional high level type JUA_ExpandedNodeId
  • added additional high level type JUA_LocalizedText

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 80.35714% with 33 lines in your changes missing coverage. Please review.

Project coverage is 43.99%. Comparing base (9a85856) to head (c651ca7).

Files Patch % Lines
src/highlevel_types.jl 83.33% 14 Missing ⚠️
src/client.jl 29.41% 12 Missing ⚠️
src/highlevel_client.jl 20.00% 4 Missing ⚠️
src/highlevel_server.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
+ Coverage   41.74%   43.99%   +2.24%     
==========================================
  Files          12       13       +1     
  Lines        3799     3923     +124     
==========================================
+ Hits         1586     1726     +140     
+ Misses       2213     2197      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomvet thomvet changed the title [WIP] add client tests and improve memory handling [WIP] add client tests and improve memory handling in tests May 29, 2024
@thomvet thomvet changed the title [WIP] add client tests and improve memory handling in tests Add client tests and improve memory handling in tests May 29, 2024
@thomvet thomvet requested a review from martinkosch May 29, 2024 23:45
Copy link
Owner

@martinkosch martinkosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, again an impressive amount of work. So far it looks good to me!

@thomvet
Copy link
Collaborator Author

thomvet commented Jun 4, 2024

I will put some more structure into the documentation and then proceed with merging this.
Once that happened, I feel that the package overall would be ready for registration in a version 0.1.0.

We've got to start somewhere and it doesn't have to be perfect from the start.

@thomvet thomvet merged commit 81d827b into main Jun 13, 2024
8 checks passed
@thomvet thomvet deleted the client-tests branch June 13, 2024 07:20
@thomvet thomvet mentioned this pull request Jun 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants