Feature: add bootstrap CI to the rwa method #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
work in progress code - does not work yet
|
Hey Martin,
The code in there for review doesn't seem to match any of the material I
sent for implementing the bootstrap. How can I best help integrate that?
Best,
Scott T
…On Tue, Jun 29, 2021 at 6:16 AM Martin Chan ***@***.***> wrote:
@martinctc <https://github.com/martinctc> requested your review on: #6
<#6> Feature: add bootstrap CI to
the rwa method.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#6 (comment)>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIT53LWAU2G7XD5VX5BQBADTVGMOLANCNFSM4XDUG75A>
.
|
Hey @stonid this pull request is still a draft and I haven't properly coded anything yet! Just wanted to add you to this, will ping you when it is ready for review. |
|
Got it. I got a ping that I was supposed to review and was confused.
…On Wed, Jun 30, 2021, 4:02 PM Martin Chan ***@***.***> wrote:
Hey Martin,
The code in there for review doesn't seem to match any of the material I
sent for implementing the bootstrap. How can I best help integrate that?
Best,
Scott T
On Tue, Jun 29, 2021 at 6:16 AM Martin Chan *@*.***>
wrote:
@martinctc <https://github.com/martinctc> https://github.com/martinctc
requested your review on: #6 <#6>
#6 <#6> Feature: add bootstrap CI to
the rwa method.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
#6 (comment) <#6 (comment)>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIT53LWAU2G7XD5VX5BQBADTVGMOLANCNFSM4XDUG75A
.
Hey @stonid <https://github.com/stonid> this pull request is still a
draft and I haven't properly coded anything yet! Just wanted to add you to
this, will ping you when it is ready for review.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIT53LRCXHVXSKZ2ETKINDDTVNZ6JANCNFSM4XDUG75A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds the bootstrap method to extract confidence intervals for
rwa().[NOTE: THIS IS STILL A DRAFT - REMOVE THIS LINE WHEN PULL REQUEST IS READY FOR REVIEW]
Changes
The changes made in this PR are:
Check
(OPTIONAL) Note
This fixes #1.