Optimize ALFG for 32-bit systems and improve initialization #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored the Additive Lagged Fibonacci Generator (ALFG) to optimize performance on 32-bit systems. - Replaced 64-bit operations with 32-bit (`uint32_t`) for faster computation on 32-bit architectures. - Implemented bitmasking (`& MASK`) to enforce 32-bit overflow and efficient modulo operations, reducing the need for costly arithmetic operations. - Enhanced initialization: Added support for user-provided initialization keys, splitting each 64-bit key into two 32-bit values to populate the state array. - Improved fallback seeding using a Linear Congruential Generator (LCG) to initialize the state if the provided key is insufficient. - Structured comments for clarity and maintenance. These changes make the ALFG faster on 32-bit systems while preserving its long period and statistical properties for non-cryptographic applications.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algorithm wasn't complying with standards, and was a substractive and not additive algorithm. This has been fixed now, as well as some minor optimizations to the efficiency for 32-bit legacy machines.
uint32_t) for faster computation on 32-bit architectures.& MASK) to enforce 32-bit overflow and efficient modulo operations, reducing the need for costly arithmetic operations.These changes make the ALFG faster on 32-bit systems while preserving its long period and statistical properties for non-cryptographic applications.