Skip to content

Commit

Permalink
Use short namespace for dr and er in config_entries (home-assistant#1…
Browse files Browse the repository at this point in the history
  • Loading branch information
epenet authored Nov 23, 2024
1 parent 0a8dde3 commit 7ba3ce6
Showing 1 changed file with 20 additions and 16 deletions.
36 changes: 20 additions & 16 deletions homeassistant/config_entries.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,12 @@
ConfigEntryNotReady,
HomeAssistantError,
)
from .helpers import device_registry, entity_registry, issue_registry as ir, storage
from .helpers import (
device_registry as dr,
entity_registry as er,
issue_registry as ir,
storage,
)
from .helpers.debounce import Debouncer
from .helpers.discovery_flow import DiscoveryKey
from .helpers.dispatcher import SignalType, async_dispatcher_send_internal
Expand Down Expand Up @@ -1948,8 +1953,8 @@ def _async_clean_up(self, entry: ConfigEntry) -> None:
"""Clean up after an entry."""
entry_id = entry.entry_id

dev_reg = device_registry.async_get(self.hass)
ent_reg = entity_registry.async_get(self.hass)
dev_reg = dr.async_get(self.hass)
ent_reg = er.async_get(self.hass)

dev_reg.async_clear_config_entry(entry_id)
ent_reg.async_clear_config_entry(entry_id)
Expand Down Expand Up @@ -2126,21 +2131,21 @@ async def async_set_disabled_by(
entry.disabled_by = disabled_by
self._async_schedule_save()

dev_reg = device_registry.async_get(self.hass)
ent_reg = entity_registry.async_get(self.hass)
dev_reg = dr.async_get(self.hass)
ent_reg = er.async_get(self.hass)

if not entry.disabled_by:
# The config entry will no longer be disabled, enable devices and entities
device_registry.async_config_entry_disabled_by_changed(dev_reg, entry)
entity_registry.async_config_entry_disabled_by_changed(ent_reg, entry)
dr.async_config_entry_disabled_by_changed(dev_reg, entry)
er.async_config_entry_disabled_by_changed(ent_reg, entry)

# Load or unload the config entry
reload_result = await self.async_reload(entry_id)

if entry.disabled_by:
# The config entry has been disabled, disable devices and entities
device_registry.async_config_entry_disabled_by_changed(dev_reg, entry)
entity_registry.async_config_entry_disabled_by_changed(ent_reg, entry)
dr.async_config_entry_disabled_by_changed(dev_reg, entry)
er.async_config_entry_disabled_by_changed(ent_reg, entry)

return reload_result

Expand Down Expand Up @@ -3182,26 +3187,26 @@ class EntityRegistryDisabledHandler:
def __init__(self, hass: HomeAssistant) -> None:
"""Initialize the handler."""
self.hass = hass
self.registry: entity_registry.EntityRegistry | None = None
self.registry: er.EntityRegistry | None = None
self.changed: set[str] = set()
self._remove_call_later: Callable[[], None] | None = None

@callback
def async_setup(self) -> None:
"""Set up the disable handler."""
self.hass.bus.async_listen(
entity_registry.EVENT_ENTITY_REGISTRY_UPDATED,
er.EVENT_ENTITY_REGISTRY_UPDATED,
self._handle_entry_updated,
event_filter=_handle_entry_updated_filter,
)

@callback
def _handle_entry_updated(
self, event: Event[entity_registry.EventEntityRegistryUpdatedData]
self, event: Event[er.EventEntityRegistryUpdatedData]
) -> None:
"""Handle entity registry entry update."""
if self.registry is None:
self.registry = entity_registry.async_get(self.hass)
self.registry = er.async_get(self.hass)

entity_entry = self.registry.async_get(event.data["entity_id"])

Expand Down Expand Up @@ -3258,7 +3263,7 @@ def _async_handle_reload(self, _now: Any) -> None:

@callback
def _handle_entry_updated_filter(
event_data: entity_registry.EventEntityRegistryUpdatedData,
event_data: er.EventEntityRegistryUpdatedData,
) -> bool:
"""Handle entity registry entry update filter.
Expand All @@ -3268,8 +3273,7 @@ def _handle_entry_updated_filter(
return not (
event_data["action"] != "update"
or "disabled_by" not in event_data["changes"]
or event_data["changes"]["disabled_by"]
is entity_registry.RegistryEntryDisabler.CONFIG_ENTRY
or event_data["changes"]["disabled_by"] is er.RegistryEntryDisabler.CONFIG_ENTRY
)


Expand Down

0 comments on commit 7ba3ce6

Please sign in to comment.