Merge pull request galaxyproject#19153 from guerler/migrate_venn

Migrate Venn Diagram to Script-Tag
martenson · Nov 18, 2024 · 4a7c220 · 4a7c220
2 parents 2d4d883 + 94e2592
commit 4a7c220
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 1,925 deletions.
diff --git a/client/gulpfile.js b/client/gulpfile.js
@@ -34,9 +34,8 @@ const STATIC_PLUGIN_BUILD_IDS = [
     "scatterplot",
     "tiffviewer",
     "ts_visjs",
-    "venn",
 ];
-const INSTALL_PLUGIN_BUILD_IDS = ["cytoscape", "ngl", "msa", "openlayers", "vizarr"]; // todo: derive from XML
+const INSTALL_PLUGIN_BUILD_IDS = ["cytoscape", "ngl", "msa", "openlayers", "venn", "vizarr"]; // todo: derive from XML
 const DIST_PLUGIN_BUILD_IDS = ["new_user"];
 const PLUGIN_BUILD_IDS = Array.prototype.concat(DIST_PLUGIN_BUILD_IDS, STATIC_PLUGIN_BUILD_IDS);
 

diff --git a/config/plugins/visualizations/venn/config/venn.xml b/config/plugins/visualizations/venn/config/venn.xml
@@ -13,8 +13,11 @@
     <params>
         <param type="dataset" var_name_in_template="hda" required="true">dataset_id</param>
     </params>
-    <entry_point entry_point_type="chart" src="script.js" css="script.css"/>
-    <groups>
+    <requirements>
+        <requirement type="npm" version="0.0.2" package="@galaxyproject/venn"/>
+    </requirements>
+    <entry_point entry_point_type="script" src="dist/index.js" css="dist/index.css" />
+    <tracks>
         <input>
             <label>Provide a label</label>
             <name>key</name>
@@ -28,5 +31,5 @@
             <type>data_column</type>
             <is_label>true</is_label>
         </input>
-    </groups>
+    </tracks>
 </visualization>
diff --git a/config/plugins/visualizations/venn/package.json b/config/plugins/visualizations/venn/package.json
diff --git a/config/plugins/visualizations/venn/src/script.js b/config/plugins/visualizations/venn/src/script.js