Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update engine to Node 14.x #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update engine to Node 14.x #49

wants to merge 2 commits into from

Conversation

maxfontani
Copy link

  1. The CommonJS variables "__filename" and "__dirname" are not available in ES modules, which caused deployment issues on Heroku.
    Added workaround as suggested in https://nodejs.org/api/esm.html#esm_no_filename_or_dirname

  2. The engine update will run the latest Node version on deployment.

  3. Adding the module type will allow the use of "import" statements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant