Add PTMA GBNO2 IBI model to polyply library [10.1021/acs.macromol.3c00141] #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fgrunewald all done here too. This makes for the 4th PTMA model in polyply:
A final question may be, do you like how I have arranged the 2 IBI models in the new |
ricalessandri
added
the
parameter submission
fgrunewald
reviewed
Aug 31, 2023
|
Also done, as in #279 (comment). |
fgrunewald
previously approved these changes
Oct 17, 2023
|
@fgrunewald I resolved the conflicts that had arisen due to the merging of the other, PTMA-related PR. |
fgrunewald
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last model to be added from 2209.02072/10.1021/acs.macromol.3c00141. It is the CG model made via Iterative Boltzmann Inversion (IBI) CG model that uses the "GBNO2" mapping. Also for PTMA.
[info]