Box from coords #321
Merged
Box from coords #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgrunewald
added
enhancement
fgrunewald
force-pushed
the
box_from_coords
branch
from
72a3c12
to
07ac373
Compare
pckroon
requested changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements new logic for handling boxes. Boxes are either defined via CLI or via provided starting coordinates. If they conflict the box with starting coordinates is taken. The 'dens' flag is completely ignored if the starting coordinates provide a box. Should this raise a warning???
This PR depends on vermouth PR #516 that implements reading of boxes.