Enforce 95% unit test coverage for new code #1112
Open
+123
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
force-pushed
the
farshid/unit-test-coverage
branch
from
0fb3fdf to
64822ff
Compare
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
force-pushed
the
farshid/unit-test-coverage
branch
from
28dcf64 to
fb7ecb2
Compare
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
force-pushed
the
farshid/unit-test-coverage
branch
from
bb7f17a to
0ecc5f5
Compare
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Error
farshidz
force-pushed
the
farshid/unit-test-coverage
branch
from
0ecc5f5 to
b59d44c
Compare
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
papa99do
reviewed
Feb 5, 2025
| pytest --durations=100 --cov=src --cov-branch --cov-context=test \ | ||
| --cov-report=html:cov_html --cov-report=xml:cov.xml --cov-report term:skip-covered \ | ||
| --md-report --md-report-flavor gfm --md-report-output pytest_result_summary.md \ | ||
| tests/unit_tests/ | tee pytest_output.txt |
There was a problem hiding this comment.
What is the plan going forward? Will we set separate coverage threshold for unit tests and integration tests? Or do we combine the coverage report and set one threshold for all the tests.
papa99do
reviewed
Feb 5, 2025
| if: github.event_name == 'pull_request' | ||
| run: | | ||
| cd marqo | ||
| diff-cover cov.xml --compare-branch=origin/${{ github.base_ref }} --fail-under=95 \ |
There was a problem hiding this comment.
If unit test coverage is enforced to be above 95, do we still need to keep the same check in unit_test_200gb_CI workflow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Have unit tests been run against this PR? (Has there also been any additional testing?)
Related Python client changes (link commit/PR here)
Related documentation changes (link commit/PR here)
Other information:
Please check if the PR fulfills these requirements