-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backwards compatibility tests - infra + preliminary tests #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changing to the right repo name
printing some things
…ic and removed some logs which were irrelevant
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 19, 2024 18:33 — with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 19, 2024 18:33 — with
GitHub Actions
Inactive
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 19, 2024 18:35 — with
GitHub Actions
Inactive
farshidz
previously approved these changes
Nov 20, 2024
wanliAlex
previously approved these changes
Nov 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
papa99do
previously approved these changes
Nov 20, 2024
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 20, 2024 02:21 — with
GitHub Actions
Failure
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 20, 2024 02:21 — with
GitHub Actions
Inactive
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 20, 2024 02:22 — with
GitHub Actions
Failure
…unit tests, 200gb unit tests
adityabharadwaj198
dismissed stale reviews from wanliAlex, farshidz, and papa99do
via
November 20, 2024 04:02
5e1d11e
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 20, 2024 04:04 — with
GitHub Actions
Failure
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 20, 2024 04:04 — with
GitHub Actions
Failure
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 20, 2024 04:05 — with
GitHub Actions
Inactive
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 20, 2024 05:42 — with
GitHub Actions
Failure
adityabharadwaj198
had a problem deploying
to
marqo-test-suite
November 20, 2024 05:42 — with
GitHub Actions
Failure
adityabharadwaj198
temporarily deployed
to
marqo-test-suite
November 20, 2024 05:42 — with
GitHub Actions
Inactive
papa99do
approved these changes
Nov 20, 2024
adityabharadwaj198
added a commit
that referenced
this pull request
Dec 18, 2024
(cherry picked from commit 13f289f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature - automated backwards compatibility tests
What is the current behavior? (You can also link to an open issue here)
Currently we manually test backwards compatibility with each release, these changes aim to automate this.
What is the new behavior (if this is a feature change)?
Automated backwards compatibility tests
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Developer testing has been done - independently
[Update 18th Nov]: End to end workflow run: https://github.com/adityabharadwaj198/marqo/actions/runs/11881673718. This includes building & pushing image to ECR, orchestrator workflow & execution workflow. Also includes the test run.
Related Python client changes (link commit/PR here)
None
Related documentation changes (link commit/PR here)
None
Other information:
Please check if the PR fulfills these requirements