Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backwards compatibility tests - infra + preliminary tests #1024

Merged
merged 108 commits into from
Nov 20, 2024

Conversation

adityabharadwaj198
Copy link
Member

@adityabharadwaj198 adityabharadwaj198 commented Oct 28, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Feature - automated backwards compatibility tests

  • What is the current behavior? (You can also link to an open issue here)
    Currently we manually test backwards compatibility with each release, these changes aim to automate this.

  • What is the new behavior (if this is a feature change)?
    Automated backwards compatibility tests

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    Developer testing has been done - independently
    [Update 18th Nov]: End to end workflow run: https://github.com/adityabharadwaj198/marqo/actions/runs/11881673718. This includes building & pushing image to ECR, orchestrator workflow & execution workflow. Also includes the test run.

  • Related Python client changes (link commit/PR here)

  • None

  • Related documentation changes (link commit/PR here)
    None

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

wanliAlex
wanliAlex previously approved these changes Nov 20, 2024
Copy link
Collaborator

@wanliAlex wanliAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

papa99do
papa99do previously approved these changes Nov 20, 2024
@papa99do papa99do merged commit 13f289f into marqo-ai:mainline Nov 20, 2024
7 of 9 checks passed
adityabharadwaj198 added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants