Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift Package Manager support #155

Merged
merged 25 commits into from
Jan 27, 2020
Merged

Conversation

ffried
Copy link
Contributor

@ffried ffried commented Nov 21, 2018

Since #118 seems to be dead, I've created a new PR.

This adds full SPM support. The following changes were necessary:

  • Add Package.swift file
  • Move minizip model map and headers into "include" subdirectory (required by SPM)
  • Work around some issues with not yet implemented APIs in corelibs-foundation (namely file creation and modification attributes and FileManager.urls(for:in:))
  • Refactor test setup to work with SPM
  • Generate LinuxMain files for SPM tests
  • Let travis run tests with SPM
  • Update README

@ffried
Copy link
Contributor Author

ffried commented Mar 27, 2019

Any news on this?

@ffried
Copy link
Contributor Author

ffried commented Mar 27, 2019

(cc @marmelroy)

@bryan1anderson
Copy link

please merge this

@choongng
Copy link

It seems @marmelroy is occupied with other things, I've merged this into my public fork and will continue maintenance there until they are back. https://github.com/choongng/Zip

@fl034
Copy link

fl034 commented Jan 23, 2020

@AvdLee could you merge this?

Copy link
Collaborator

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! As soon as CI succeeds, we can merge

@ffried ffried mentioned this pull request Jan 24, 2020
@ffried
Copy link
Contributor Author

ffried commented Jan 27, 2020

@AvdLee Thanks for the review and for getting this on!
The CI seems to have stalled. I've added Swift 5.1 support for SPM as well (literally just a copy of the Package.swift declaring 5.1 tools). Let's see if the new CI build now works 🙂

@AvdLee
Copy link
Collaborator

AvdLee commented Jan 27, 2020

Looks good! Merging in 🚀

@AvdLee AvdLee merged commit 80b1c30 into marmelroy:master Jan 27, 2020
@svoip
Copy link

svoip commented Jan 28, 2020

@AvdLee Can you make a new release as well?
It seems package is being recognized, but not it is not yet aligned with the correct version of the library.
I am getting this error:

image

@mcritz
Copy link

mcritz commented Jan 28, 2020

@svoip Be sure you’re using the latest SPM tools. The top line of your Package.swift file should be:

// swift-tools-version:5.1

@ffried
Copy link
Contributor Author

ffried commented Jan 28, 2020

For now, you can also use master as target.
In Package.swift, you can use .branch("master") instead of from: "1.1.0" as target of your dependency.
In Xcode, you can select the target when adding the dependency as well.

@ffried
Copy link
Contributor Author

ffried commented Jan 28, 2020

Or use .revision("80b1c3005ee25b4c7ce46c4029ac3347e8d5e37e") if you want to stick to the current HEAD commit of the master branch. Be aware, though, that this might break once master progresses.

@AvdLee
Copy link
Collaborator

AvdLee commented Jan 30, 2020

@ffried @mcritz I'm not actively working on this project and don't have the time to do a new release. Maybe @marmelroy can make a new release or make one of you capable to do that

@trevor-sonic
Copy link

I have same issue as @svoip .
I could use master but it is not ideal.
I'm using Xcode 11.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants