-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Handle HashRouter & BrowserRouter for Supabase redirections #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djhi
requested changes
Aug 8, 2024
djhi
requested changes
Aug 8, 2024
djhi
requested changes
Aug 8, 2024
Co-authored-by: Gildas Garcia <[email protected]>
Co-authored-by: Gildas Garcia <[email protected]>
arimet
force-pushed
the
feat/allow-hash-router
branch
from
August 8, 2024 09:53
23cdfec
to
4affe7b
Compare
djhi
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As a developer, I want to be able to choose between the HashRouter and the BrowserRouter.
Solution
Modify the DataProvider's handleCallback function and useSupabaseAccessToken to retrieve query params when using a URL Hash or history url.
Other
Improve documentation
How to test
BrowserRouter
redirect_to
parameter fromhttp://localhost:8000
tohttp://localhost:8000/auth-callback
.HashRouter
App.ts
public/auth-callback/index.html
is createdredirect_to
withhttp://localhost:8000/auth-callback/index.html