Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(authProvider): It is no longer possible to access a page using direct URL if user is logged out #65

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

arnault-dev
Copy link
Contributor

@arnault-dev arnault-dev commented Aug 5, 2024

Problem

It was possible to access restricted pages via URL if user was logged out

Solution

Handle AuthSessionMissingError from supabase in supabaseAuthProvider.checkError

How To Test

  1. Run the local demo
  2. Make sure you are not logged in (sign out if necessary)
  3. Browse to http://localhost:8001/contacts

BEFORE: user would see the CRM layout, with an empty ContactList page (and not be redirected to the login page)
AFTER: user is automatically redirected to the login page

@slax57 slax57 added this to the 3.0.1 milestone Aug 5, 2024
@slax57 slax57 merged commit 608e44a into main Aug 5, 2024
5 checks passed
@slax57 slax57 deleted the fix/auth-provider-error branch August 5, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants