Build a docker image with greenframe-cli

[vpeltot]

Closes #18

[fzaninotto]

Nice!

[fzaninotto]

How is this part related to greenframe?

[vpeltot]

gcloud command line tools are required to use kubectl ... commands in the Google Cloud Platform kubernetes execution context, especially for all authentication steps.
It's the same for Azure and AWS.

I think it would be great to offer all the necessary tools for the major cloud providers (GCP, AWS, Azure) and create a specific version of the greenframe-cli image.

I added a new make command (which can be used in the GitHub workflow) to build these images:

DOCKER_BUILDKIT=1 docker build -t greenframe-cli:latest -t greenframe-cli:$(PACKAGE_VERSION) . --target base

for the base image, and:

DOCKER_BUILDKIT=1 docker build -t greenframe-cli:$(PACKAGE_VERSION)-gcp . --target gcp 
etc ...

for the specific cloud providers.

One greenframe-cli version will have these docker version:

• greenframe-cli:latest
• greenframe-cli:1.4.4
• greenframe-cli:1.4.4-gcp
• greenframe-cli:1.4.4-azure
• greenframe-cli:1.4.4-...

[fzaninotto]

This is not something we want to maintain in this repository. I prefer that we provide a cloud-agnostic base image, and leave to the community the cloud-specific images.

[fzaninotto]

Awesome! Your PR is in Draft, what's left to finish it?

[vpeltot]

I just pushed a new commit with

• Update README file to add a "docker" section
• Change the greenframe-cli image name to just greenframe to be consistent with the command line. I think it's better to have $ docker run marmelab/greenframe analyze ... istead of $ docker run marmelab/greenframe-cli analyze ...
• Add an entrypoint & default --version command

[vpeltot]

@fzaninotto
Can you set the environment variables DOCKER_REGISTRY_USER and DOCKER_REGISTRY_PASS values with your docker hub credentials?

[floo51]

Hello Vincent,

I've checked out locally and tried to run a greenframe analyze using the provided Dockerfile:

# from project root
docker build -t greenframe-docker-in-docker-test .
docker run -v $(pwd)/:/app greenframe-docker-in-docker-test analyze -C ./.greenframe.e2e.yml

I'm getting an error about being unable to connect to the Docker daemon:

❌ main scenario failed
This scenario fail during the execution:
Command failed: docker create --tty --name greenframe-runner --rm -e HOSTIP=172.17.0.3 --add-host localhost:172.17.0.3  mcr.microsoft.com/playwright:v1.28.1-focal
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?

I thought this was dind based but now realize it might be dood (Docker outside of Docker), do we have to map the docker sock from host to container for it to work?

If yes, we need to document it, and we could use an alpine based image so that the final image is lighter, I worked on a dood alpine image so it might come handy.

[npotier]

Hello. First of all I would like to thank you for this project.

Juste my 2 cents here. We have created a small and simple Docker image in order to run greenframe-cli : https://github.com/acseo/docker-greenframe-cli

You cans use it to test a remote or a local website :

$ docker run -it -v /var/run/docker.sock:/var/run/docker.sock acseo/greenframe-cli \ 
    greenframe analyze https://www.acseo.fr

$ docker run -it \
    -e "DEBUG=*" \
    --network="host" \
    -v $(pwd)/greeframe.yml:/app/greenframe.yml \
    -v $(pwd)/scenario.js:/app/scenario.js \
    -v /var/run/docker.sock:/var/run/docker.sock \
    acseo/greenframe-cli greenframe analyze -C /app/greenframe.yml http://my-app.local /app/greenframe.js

Maybe it will be useful for someone 😃