Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jung/staking #69
base: master
Are you sure you want to change the base?
Jung/staking #69
Changes from 68 commits
1be8e65
c8dedb3
67b6c38
bf7fdb6
27fafca
f4441fd
3b6dbca
215b33c
78f02d0
9936d1c
9126919
5f873f6
657119c
170567c
c8928f1
4ba1ee4
e3a947a
33c92e8
335deeb
7193efb
1291204
98499ee
b27093d
4d8461e
42a6c02
933809d
0a277b7
40e0b01
2463e2c
1d90243
2964e1d
40e4eee
eb8a9af
a65ea70
5890845
1738b0f
e239d01
a10c4c3
d6ebec6
c788c51
467efcd
6525aa5
c2060cb
5c00314
59e6209
3fe574e
46369f6
66a646c
dac1008
230b8ba
dfc1a8b
97d4152
7dab574
842c686
10d3ab6
3cc6914
5bb69e6
a464606
fe4a8dc
9f54798
2b5a282
a766094
8a1e5c2
f00b55a
cd62599
2c6cb90
a2c92ed
8d20006
6d0c15f
2c8a0bc
c67c32b
b202fe8
193a86b
a3d605e
1f4afc1
dac7f80
2262916
8d86dd3
ffea6b6
245beb7
d265222
819c13f
f31ae90
2dce130
3195325
fae46b1
948ea0e
e60d824
2575a1f
cd47892
2204958
8c2cbe0
c934123
683e429
f4df6e1
a421c16
f8422ec
96ffa9f
fb50a1c
3c2e6fa
2a2c043
a04883b
a5a761d
082b2e3
4d0357f
4412bf6
42aba9f
4bd8823
c716bd0
6db8ede
66ca214
2ca8ae2
9513350
4b3dd14
359f637
9671f96
5ea15b5
dec69fd
d3d7f24
25a981f
2696f61
06276b8
9339d7d
a1798aa
18c98a6
c2f1192
5b75efa
29fa07d
a5d9da4
99b3d3c
cc59e38
e74888c
38fed2d
c6caeb0
0d11aa9
5f8a4d3
77ca2da
696b8e7
fb9aed3
974df18
4b74dbd
d1109ca
106fc42
82442e3
7ef70c5
f6f8231
1376f23
7424f80
57ac65d
a245830
9a6019f
30e11a2
22ddb9d
a4b58a2
ae2ac28
d1fba22
95f7fcb
45d17de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slash functions need to be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this supposed to be automatically slashed for not submitting proof?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
user can manually slash if they want to. Only native staking is slashed(they are still stored with contract to be given to slash_transmitter) in that case and user gets their tokens for the job back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[discuss]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if manual)
the anyone(most likely fee payer) calls
JobManager.slash()
and thisif manual slash -> 2step
step1) manual fee refund
step2) unlock by slash result transmission
1 step
slash result submission unlocks the stake(operator's locked stake will be given to the slashRequest transmitter)
what's needed
: manual fee refund mechanism (will need to store the amount of fee paid when job creation)