Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bep022 #1

Merged
merged 7 commits into from
Sep 7, 2023
Merged

Bep022 #1

merged 7 commits into from
Sep 7, 2023

Conversation

markmikkelsen
Copy link
Owner

--- PLEASE READ AND DELETE THE TEXT BELOW BEFORE OPENING THE PULL REQUEST ---

See the CONTRIBUTING guide. Specifically:

  • Please keep the title of your Pull Request (PR) short but informative - it will
    appear in the changelog.
  • If you do not want a PR to appear in the changelog, it must receive the exclude-from-changelog label.
  • Please ensure your name is credited on our Contributors appendix.
    To add your name, please edit our Contributors wiki and add your name with the type of contribution.
    For assistance, please tag @bids-standard/maintainers.
  • Use one of the following prefixes in the title of your PR:
    • [ENH] - enhancement of the specification that adds a new feature or
      support for a new data type
    • [FIX] - fix of a typo or language clarification
    • [INFRA] - changes to the infrastructure automating the specification
      release (for example building HTML docs)
    • [SCHEMA] - changes to the BIDS schema and/or related code
    • [MISC] - everything else including changes to the file listing
      contributors
  • If you are opening a PR to obtain early feedback, but the changes
    are not ready to be merged (also known as a "Work in Progress" PR), please
    use a Draft PR.
  • After opening the PR, our continuous integration services will automatically check your contribution for formatting errors and render a preview of the BIDS specification with your changes.
    To see the checks and preview, scroll down and click on the show all checks link.
    From the list, select the Details link of the ci/circleci: build_docs artifact check to see the preview of the BIDS specification.
  • If you are updating the schema and you need to subsequently make changes to the bidsschematools code (validation, tests, rendering), this means your PR probably introduces a compatibility breaking change and you should increment the minor version (the second number) in bids-specification/src/schema/SCHEMA_VERSION.

--- PLEASE READ AND DELETE THE TEXT ABOVE BEFORE OPENING THE PULL REQUEST ---

rwblair and others added 7 commits August 24, 2023 17:48
BloodPlasma requirement in tabular data didn't check if the corresponding json was true. All jsons are required to have the PlasmaAvail field, so any dataset with PlasmaAvail false would fail this check.
* Remove redundant phase entity rule.

* Add missing newline.

* Adjust check messages.

* Add note about 89+ to age column description.
* [schema][fix] intersect() -> intersects()

* [schema][fix] Identify MEG data files with task entity

Closes bids-standard/bids-examples#398

* [schema][fix] Remove redundant modality checks

* [schema][fix] modalities are lowercase

* [schema][fix] Better selectors for MRI images

* [schema][fix] More modality/datatype cleanups

* [schema] Clarify name of Units metadata field

* [schema] Typo: Antobodies -> Antibodies

* FIX: metabolite_polar_fraction is recommended at most in 1.6.0

* FIX: Drop redundant check for fields in sidecar

* SCHEMA: Reorder IntendedFor/B0FieldIdentifier rules

* FIX: Move "anat" rule for _phase images to proper location, update selectors
updates:
- [github.com/pre-commit/mirrors-prettier: v3.0.2 → v3.0.3](pre-commit/mirrors-prettier@v3.0.2...v3.0.3)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@markmikkelsen markmikkelsen merged commit 08201f1 into markmikkelsen:bep022 Sep 7, 2023
2 checks passed
markmikkelsen pushed a commit that referenced this pull request Nov 24, 2023
ENH: Remove Atlas metadata, update imaging derivatives text around seg-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants