Master to blocks #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PocketMine/PocketMine-MP#4087 didn't get reviewed properly, or at all 🤦
Not up to the task of implementing rail connectivity today, some other time
…tivated() (needless extra confusion)
must be < 2 blocks from either half of the bed
Liquid still needs a total rewrite, but at least it won't constantly waste CPU anymore.
way too fast to grow back though :S
$ shopt -s globstar $ sed -i 's/[ \t]*$//' src/pocketmine/*/**.php :P
- Fixed log writes being blocking (these were executed on a thread, but IN A SYNCHRONIZED BLOCK - what the fuck shoghi?!) - Fixed log file being open for reading as well as writing - The logger will now be buffered for 25ms before writing to disk, as it should have been to begin with. - Moved the log resource to a local variable (it's unsafe to try to access resources from different threads, this takes away the ability to do so) - Fixed line endings to use PHP_EOL instead of hardcoded LF, fix viewing logs in Notepadi
* Do not create new NBT objects on Tile::getSpawnCompound() * PocketMine's string formatting * Remove more useless array indices and create lesser new NBT objects. * Remove unused imports and type-hint Sign::setText() params * Do not mess with Sign::setText() params due to pmmp#1204 * Fix formatting * Make getSpawnCompound() final and add abstract addAdditionalSpawnData() * Make the same changes for Bed tile * Fix a missing "->" and remove some unneeded int casting.
PhpStorm, pls tell me why you only found this _now_ and not back in January when I started using PhpStorm...
…ng return for Block->hasMetadata() reported in pmmp#1285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Relevant issues
Changes
API changes
Behavioural changes
Backwards compatibility
Follow-up
Tests