Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent shimmer animation from affecting initial layout of the view #20

Merged
merged 2 commits into from
Jan 28, 2024
Merged

Prevent shimmer animation from affecting initial layout of the view #20

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3941837
Prevent shimmer animation from affecting the initial layout cycle of …
ast3150 Nov 15, 2023
4290558
Remove animation(nil) because it's not strictly necessary
ast3150 Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Sources/Shimmer/Shimmer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,15 @@ public struct Shimmer: ViewModifier {

public func body(content: Content) -> some View {
content
.animation(nil, value: false) // Prevent animation from propagating to the modified view
ast3150 marked this conversation as resolved.
Show resolved Hide resolved
.mask(LinearGradient(gradient: gradient, startPoint: startPoint, endPoint: endPoint))
.animation(animation, value: isInitialState)
.onAppear {
isInitialState = false
// Delay the animation until the initial layout is established
// to prevent animating the appearance of the view
DispatchQueue.main.asyncAfter(deadline: .now()) {
ast3150 marked this conversation as resolved.
Show resolved Hide resolved
isInitialState = false
}
}
}
}
Expand Down