✨ Added warning when pushing sensitive files #73
Conversation
Mario-SO
changed the title
|
It seems that we differ in fmt settings? cause i see there are many changes on how the imports are done? |
src/lib.rs
Outdated
| let path_buf = PathBuf::from(&path); | ||
|
|
||
| // Check for sensitive files or directories | ||
| if utils::check_for_sensitive_files_or_directories_recursive(&path_buf) { |
There was a problem hiding this comment.
just import this so you can use it check_for_sensitive_files_or_directories_recursive
There was a problem hiding this comment.
I don't get what you mean here
src/lib.rs
Outdated
| let _ = remove_dir_all(&test_dir); | ||
|
|
||
| // Restore the original prompt function | ||
| // utils::prompt_user_for_confirmation = original_prompt; |
src/utils.rs
Outdated
| // Function to check for the presence of sensitive files or directories | ||
| pub fn check_for_sensitive_files_or_directories(path: &Path) -> bool { | ||
| let env_file_exists = path.join(".env").exists(); | ||
| let git_dir_exists = path.join(".git").exists(); |
There was a problem hiding this comment.
maybe we can just look for any .file we have? and just display them all?
And let the user decide if it's safe?
Crap, you are totally right, my bad. Will fix and PR again. PS: Also saw the rest of the comments you made. |
src/lib.rs
Outdated
| let path_buf = PathBuf::from(&path); | ||
|
|
||
| // Check for sensitive files or directories | ||
| if utils::check_for_sensitive_files_or_directories_recursive(&path_buf) { |
There was a problem hiding this comment.
| if utils::check_for_sensitive_files_or_directories_recursive(&path_buf) { | |
| if check_for_sensitive_files_or_directories_recursive(&path_buf) { |
Sorry i just meant like this.
There was a problem hiding this comment.
also the name is a bit tbh, can we work on something smaller?
There was a problem hiding this comment.
Oh ok I get you now, also, yeah the name is way too descriptive XD
|
you have to run and Cause the CI fails |
|
Ok I see, sorry for all the inconveniences this PR is causing first of all. Also wanted to ask, when running warning: this function depends on never type fallback being `()`
--> src/dependency_downloader.rs:18:1
|
18 | / pub async fn download_dependencies(
19 | | dependencies: &[Dependency],
20 | | clean: bool,
21 | | ) -> Result<(), DownloadError> {
| |______________________________^
|
= warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
= note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
= help: specify the types explicitly
note: in edition 2024, the requirement `!: std::iter::FromIterator<()>` will fail
--> src/dependency_downloader.rs:35:16
|
35 | .collect::<Result<_, _>>()?;
| ^^^^^^^^^^^^
= note: `#[warn(dependency_on_unit_never_type_fallback)]` on by defaultThe rest of the warnings are resolved and also ran the I will push again and await your feedback once more. Again sorry to bother this much with such a minor PR. |
ah no worries at all, thank you for taking the time to get this done. |
|
Sure, will solve it asap |
|
actually i m gonna solve them cause it seems there are more now after I did an update. will solve then if everything is ok I m gonna merge this one |
|
It no longer pops any warnings. |
As discussed in here for issue #67, added a user warning when pushing .env or .git/
PS: Missing tests, looking forward to feedback.