Improvement: create dependency folders only after successful install #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, soldeer would unconditionally create a new folder for each dependency, regardless of whether the installation was successful. If we attempt failed installation repeatedly under different names, it could lead to the accumulation of multiple empty folders within the dependencies directory.
Changes
With the PR's changes, a new folder for a dependency will only be created if the installation process completes successfully. This improvement prevents the creation of unnecessary empty folders.