chore(deps): bump zip-extract to 0.2.0 #161
Conversation
DaniPopes
force-pushed
the
zip-extract-0_2
branch
from
b5204a7
to
8b126d3
Compare
| zip-extract = "0.1.3" | ||
| zip = { version = "2.1.3", default-features = false, features = [ | ||
| "deflate", | ||
| "bzip2", |
There was a problem hiding this comment.
Do we need bzip2, knowing we only use this lib to create zip archives?
There was a problem hiding this comment.
Used to extract downloaded zip archives 8b126d3
There was a problem hiding this comment.
But we use zip-extract for that, and it doesn't have a feature flag for bzip2.
There was a problem hiding this comment.
Also, at that point why not add the other compression techniques like flate2, zlib, lzma etc? (if the goal is to increase compatibility)
There was a problem hiding this comment.
zip-extract is a thin wrapper around zip
There was a problem hiding this comment.
I've added support upstream and added in 5ee2b3e, in any case if the versions diverge it duplicates zip again which is not good
There's no need if the only one used is bzip2, we only need to extract what we compressed ourselves
There was a problem hiding this comment.
There's no need if the only one used is bzip2, we only need to extract what we compressed ourselves
That's not strictly true, users can pass a custom URL for their dependencies, and we need to decompress the result archive. This could potentially be any format supported by zip if we add the relevant flags. So it's a decision we can make: do we want to support URLs with files only containing zip/deflate, or do we want to support more archive formats. Still don't understand where bzip2 comes into play, what's the reason for adding it, sorry for my confusion 😕 It's not a standard format for zip archives.
There was a problem hiding this comment.
Thanks for fixing the upstream flags though! That's nice to have the same options as zip
There was a problem hiding this comment.
That makes sense, however I would probably enforce the method; cargo uses .crate files which are .tar.gz
My main problem with enabling more compression methods is that most of them are C libraries so it adds a lot of dependencies, and I don't know how widely used they are to justify this cost
For example the zip linux manpage lists only deflate and bzip2; bzip2 is required for a test to pass in this repository
There was a problem hiding this comment.
Oh okay my bad, I didn't know one test relied on bzip2 and that it was mentioned in the manpage. the flate feature flag covers tar.gz right? If so then I think I'm okay with the current choice!
DaniPopes
force-pushed
the
zip-extract-0_2
branch
from
8b126d3
to
eac9be5
Compare
Gets rid of old duplicate
zipdependencies.