Recursive Dependencies #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps which can install the dependencies of that dependency recursively
beeb
reviewed
Aug 8, 2024
src/dependency_downloader.rs
Outdated
| @@ -287,6 +285,49 @@ fn transform_git_to_http(url: &str) -> String { | |||
| } | |||
| } | |||
|
|
|||
| fn check_recursiveness(dependency: &Dependency) -> Result<()> { | |||
There was a problem hiding this comment.
This function is not a check (which I would expect to have no side effects). A better name would be install_subdependencies
beeb
reviewed
Aug 8, 2024
src/dependency_downloader.rs
Outdated
| .stdout(Stdio::piped()) | ||
| .stderr(Stdio::piped()); | ||
|
|
||
| let status = result.status().unwrap(); |
There was a problem hiding this comment.
Avoid unwrap, better to report the error instead of panicking? If don't want to return an error because the program must absolutely panic here, then at least use expect() with a descriptive message. Same comment on line 308
beeb
reviewed
Aug 8, 2024
src/dependency_downloader.rs
Outdated
| @@ -117,6 +119,10 @@ pub async fn download_dependency( | |||
| } | |||
| } | |||
| }; | |||
|
|
|||
| if recursive_deps { | |||
| check_recursiveness(dependency).unwrap(); | |||
There was a problem hiding this comment.
No unwrap here! Just propagate the error with question mark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the recursive dependencies.
if you set --recursive-deps when you run install or update or you set the config
[soldeer]
recursive-deps = true
Soldeer will install automatically the submodule dependencies and soldeer dependencies of the dependency you want to install.
Closes #115