Keyboard light fixes (#47)

* Fix bindings freezing / breaking when hitting certain shortcuts/hotkeys * Fix keys getting stuck if they were heldwhile window became inactive * Simplify else statement tip from @AdrianCassar --------- Co-authored-by: Clippy95 <[email protected]>
marinesciencedude · Dec 19, 2024 · 184fb00 · 184fb00
1 parent a4f2b9b
commit 184fb00
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/xenia/hid/winkey/winkey_input_driver.cc b/src/xenia/hid/winkey/winkey_input_driver.cc
@@ -583,7 +583,7 @@ X_RESULT WinKeyInputDriver::GetState(uint32_t user_index,
         const auto vk_key = static_cast<ui::VirtualKey>(i);
 
         if (!binds.count(vk_key)) {
-          break;
+          continue;
         }
 
         const auto binding = binds.at(vk_key);
@@ -670,6 +670,10 @@ X_RESULT WinKeyInputDriver::GetState(uint32_t user_index,
         }
       }
     }
+  } else {  // So keys don't get 'stuck' if they were held previously when
+            // tabbing in and out from the window
+    memset(key_states_, 0, 256);
+    mouse_events_ = {};
   }
 
   out_state->packet_number = packet_number_;