Skip to content

Commit

Permalink
fix: make scratchpad scrollable (#3076)
Browse files Browse the repository at this point in the history
## 📝 Summary

<!--
Provide a concise summary of what this pull request is addressing.

If this PR fixes any issues, list them here by number (e.g., Fixes
#123).
-->
Fixes #3073 . Each individual part can be scrolled (code editor, output
area, console output) and the whole scratchpad can be scrolled too. I
think it maintains the feel of scratchpad while handling long inputs /
outputs.

I'm not sure if it breaks anything else, so plan to test it locally a
while.

<img width="300" alt="Screenshot 2024-12-06 at 7 26 57 PM"
src="https://github.com/user-attachments/assets/0c777a17-8eca-4070-8ce2-bb5d7bf181ef">

## 🔍 Description of Changes

<!--
Detail the specific changes made in this pull request. Explain the
problem addressed and how it was resolved. If applicable, provide before
and after comparisons, screenshots, or any relevant details to help
reviewers understand the changes easily.
-->

## 📋 Checklist

- [X] I have read the [contributor
guidelines](https://github.com/marimo-team/marimo/blob/main/CONTRIBUTING.md).
- [ ] For large changes, or changes that affect the public API: this
change was discussed or approved through an issue, on
[Discord](https://marimo.io/discord?ref=pr), or the community
[discussions](https://github.com/marimo-team/marimo/discussions) (Please
provide a link if applicable).
- [ ] I have added tests for the changes made.
- [X] I have run the code and verified that it works as expected.

## 📜 Reviewers

<!--
Tag potential reviewers from the community or maintainers who might be
interested in reviewing this pull request.

Your PR will be reviewed more quickly if you can figure out the right
person to tag with @ -->

@akshayka OR @mscolnick
  • Loading branch information
Light2Dark authored Dec 6, 2024
1 parent 4129e02 commit 47b5d1d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion frontend/src/components/scratchpad/scratchpad.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ export const ScratchPad: React.FC = () => {
</Button>
</Tooltip>
</div>
<div className="flex-1 divide-y relative">
<div className="flex-1 divide-y relative overflow-hidden flex flex-col">
{renderBody()}
{renderHistory()}
</div>
Expand Down

0 comments on commit 47b5d1d

Please sign in to comment.