Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topk refactor #770

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a5a52a8
Adds cub as a submodule
rhenry-nv Oct 17, 2020
7085b44
Redo topk implementation
rhenry-nv Oct 19, 2020
bae684c
Cuda 11 Support for nvidia's improvements
XapaJIaMnu Oct 21, 2020
464bd52
Remove redundant includes in topk
rhenry-nv Oct 22, 2020
023f7e1
Fixes topk when all elements are the lowest value of the input type
rhenry-nv Oct 23, 2020
e463f76
Adds license to nth_element.cu
rhenry-nv Oct 23, 2020
66d879c
Removes unneccessary cub include outside of header guards
rhenry-nv Oct 26, 2020
ce2da48
Handles not found in topk stage 2
rhenry-nv Oct 26, 2020
2270945
Removes unneeded include
rhenry-nv Oct 26, 2020
5bdcf5d
Refactor topk to make more generic. Towards integration with topk ope…
rhenry-nv Dec 4, 2020
7c369ea
Refactors topk to replace the implementation of the existing topk ope…
rhenry-nv Dec 4, 2020
32445a9
Finishes refactor of topk.cuh and replaces the topk call in topk.cu. …
rhenry-nv Dec 4, 2020
e028945
Adds comment to topKLauncher template parameters. Regression tests pass
rhenry-nv Dec 4, 2020
fa7a616
Fix change log
rhenry-nv Dec 4, 2020
640aad3
Removes cub include outside of header guard. IDE keep automatically a…
rhenry-nv Dec 4, 2020
9f4ae14
Adds license to topk.cu
rhenry-nv Dec 4, 2020
9ad2ca8
Fixes TopK so that the correct result is returned if the input array …
rhenry-nv Dec 11, 2020
f9e8b83
Sets the minimal value to inf in topk
rhenry-nv Dec 11, 2020
8ac9300
Adds comments around topk struct, renames fields so that they are mor…
rhenry-nv Dec 18, 2020
808d2f4
Adds comments to topk_stage1
rhenry-nv Dec 19, 2020
835b080
Fixes code in topk_stage2
rhenry-nv Dec 19, 2020
abf2a58
Fixes some comments
rhenry-nv Dec 19, 2020
b77725e
Fixes renames beams_per_batch to items_per_row and starts commenting …
rhenry-nv Dec 19, 2020
f6641ca
Adds more comments and gives some variables better names
rhenry-nv Dec 19, 2020
ea26be4
Removes individual NVIDIA licenses and adds NVIDIA to the LICENSE.md …
rhenry-nv Dec 19, 2020
c6a4df1
changes some variable names
rhenry-nv Dec 19, 2020
5c7f240
Merge master into topk_refactor
rhenry-nv Mar 5, 2021
3130aa7
Removes diff marker from changelog
rhenry-nv Mar 5, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,6 @@
[submodule "src/3rd_party/simple-websocket-server"]
path = src/3rd_party/simple-websocket-server
url = https://github.com/marian-nmt/Simple-WebSocket-Server
[submodule "src/3rd_party/cub"]
path = src/3rd_party/cub
url = https://github.com/NVIDIA/cub
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
## [Unreleased]

### Added

- Includes cub as a dependency
- Replaces the topK implementation in nth_element.cu and topk.cu
- Local/global sharding with MPI training via `--sharding local`
- fp16 support for factors.
- Correct training with fp16 via `--fp16`.
Expand Down
2 changes: 2 additions & 0 deletions LICENSE.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ MIT License
Copyright (c) 2016 Marcin Junczys-Dowmunt, the University of Edinburgh, Adam
Mickiewicz University

Copyright (c) 2020 NVIDIA Corporation

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
Expand Down
1 change: 1 addition & 0 deletions src/3rd_party/cub
Submodule cub added at 52d58a
485 changes: 485 additions & 0 deletions src/3rd_party/topk.cuh

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
add_definitions(-DCUB_IGNORE_DEPRECATED_CPP_DIALECT=1)
add_definitions(-DTHRUST_IGNORE_DEPRECATED_CPP_DIALECT=1)
add_subdirectory(3rd_party)

include_directories(.)
Expand Down
Loading