Add the activeDeadlineSeconds attribute to the backup pod #1109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to let you know, we have merged a new change to prevent deadlocks while backups are being taken: This will be shortly released in Regarding next steps in your PR, you need to set the mariadb-operator/pkg/builder/batch_builder.go Line 107 in 3625487 |
|
This PR is stale because it has been open 60 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backup pod gets stuck while dumping the data from one of our clusters. It happens irregularly for about 1/3 of the hourly jobs. I have yet to figure out the issue - possibly a deadlock situation? In the meantime, I thought it'd be helpful if the pod gets removed automatically when the job hasn't succeeded in a reasonable amount of time. That way, the stuck pod isn't blocking the cronjob from scheduling new pods.
I'm opening this PR as a way of illustrating my request. I do not know if these code changes are complete and functional. I guess including a test for this newly added field would be desirable.