Skip to content

Commit

Permalink
epmd: Unify systemd autoconf macros usage
Browse files Browse the repository at this point in the history
Don't use both HAVE_SYSTEMD_DAEMON and HAVE_SYSTEMD_SD_DAEMON - use only
the former one and remove the latter one entirely.

Signed-off-by: Peter Lemenkov <[email protected]>
  • Loading branch information
lemenkov authored and garazdawi committed Nov 24, 2014
1 parent 59740d8 commit 5db2345
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 18 deletions.
16 changes: 8 additions & 8 deletions erts/epmd/src/epmd.c
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,9 @@ int main(int argc, char** argv)
g->nodes.reg = g->nodes.unreg = g->nodes.unreg_tail = NULL;
g->nodes.unreg_count = 0;
g->active_conn = 0;
#ifdef HAVE_SYSTEMD_SD_DAEMON_H
#ifdef HAVE_SYSTEMD_DAEMON
g->is_systemd = 0;
#endif
#endif /* HAVE_SYSTEMD_DAEMON */

for (i = 0; i < MAX_LISTEN_SOCKETS; i++)
g->listenfd[i] = -1;
Expand Down Expand Up @@ -251,11 +251,11 @@ int main(int argc, char** argv)
else
usage(g);
epmd_cleanup_exit(g,0);
#ifdef HAVE_SYSTEMD_SD_DAEMON_H
#ifdef HAVE_SYSTEMD_DAEMON
} else if (strcmp(argv[0], "-systemd") == 0) {
g->is_systemd = 1;
argv++; argc--;
#endif
#endif /* HAVE_SYSTEMD_DAEMON */
} else
usage(g);
}
Expand Down Expand Up @@ -461,11 +461,11 @@ static void usage(EpmdVars *g)
fprintf(stderr, " Forcibly unregisters a name with epmd\n");
fprintf(stderr, " (only allowed if -relaxed_command_check was given when \n");
fprintf(stderr, " epmd was started).\n");
#ifdef HAVE_SYSTEMD_SD_DAEMON_H
#ifdef HAVE_SYSTEMD_DAEMON
fprintf(stderr, " -systemd\n");
fprintf(stderr, " Wait for socket from systemd. The option makes sense\n");
fprintf(stderr, " when started from .socket unit.\n");
#endif
#endif /* HAVE_SYSTEMD_DAEMON */
epmd_cleanup_exit(g,1);
}

Expand Down Expand Up @@ -594,10 +594,10 @@ void epmd_cleanup_exit(EpmdVars *g, int exitval)
free(g->argv[i]);
free(g->argv);
}
#ifdef HAVE_SYSTEMD_SD_DAEMON_H
#ifdef HAVE_SYSTEMD_DAEMON
sd_notifyf(0, "STATUS=Exited.\n"
"ERRNO=%i", exitval);
#endif // HAVE_SYSTEMD_SD_DAEMON_H
#endif /* HAVE_SYSTEMD_DAEMON */
exit(exitval);
}

Expand Down
8 changes: 4 additions & 4 deletions erts/epmd/src/epmd_int.h
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,9 @@
# include "sys/select.h"
#endif

#ifdef HAVE_SYSTEMD_SD_DAEMON_H
#ifdef HAVE_SYSTEMD_DAEMON
# include <systemd/sd-daemon.h>
#endif
#endif /* HAVE_SYSTEMD_DAEMON */

/* ************************************************************************ */
/* Replace some functions by others by making the function name a macro */
Expand Down Expand Up @@ -340,9 +340,9 @@ typedef struct {
int listenfd[MAX_LISTEN_SOCKETS];
char *addresses;
char **argv;
#ifdef HAVE_SYSTEMD_SD_DAEMON_H
#ifdef HAVE_SYSTEMD_DAEMON
int is_systemd;
#endif
#endif /* HAVE_SYSTEMD_DAEMON */
} EpmdVars;

void dbg_printf(EpmdVars*,int,const char*,...);
Expand Down
12 changes: 6 additions & 6 deletions erts/epmd/src/epmd_srv.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ void run(EpmdVars *g)
}
else
{
#endif
#endif /* HAVE_SYSTEMD_DAEMON */

dbg_printf(g,2,"try to initiate listening port %d", g->port);

Expand Down Expand Up @@ -312,7 +312,7 @@ void run(EpmdVars *g)
}
#ifdef HAVE_SYSTEMD_DAEMON
}
#endif
#endif /* HAVE_SYSTEMD_DAEMON */

#if !defined(__WIN32__) && !defined(__OSE__)
/* We ignore the SIGPIPE signal that is raised when we call write
Expand All @@ -330,13 +330,13 @@ void run(EpmdVars *g)
FD_ZERO(&g->orig_read_mask);
g->select_fd_top = 0;

#ifdef HAVE_SYSTEMD_SD_DAEMON_H
#ifdef HAVE_SYSTEMD_DAEMON
if (g->is_systemd)
for (i = 0; i < num_sockets; i++)
select_fd_set(g, listensock[i]);
else
{
#endif
#endif /* HAVE_SYSTEMD_DAEMON */
for (i = 0; i < num_sockets; i++)
{
if ((listensock[i] = socket(FAMILY,SOCK_STREAM,0)) < 0)
Expand Down Expand Up @@ -399,12 +399,12 @@ void run(EpmdVars *g)
}
select_fd_set(g, listensock[i]);
}
#ifdef HAVE_SYSTEMD_SD_DAEMON_H
#ifdef HAVE_SYSTEMD_DAEMON
}
sd_notifyf(0, "READY=1\n"
"STATUS=Processing port mapping requests...\n"
"MAINPID=%lu", (unsigned long) getpid());
#endif
#endif /* HAVE_SYSTEMD_DAEMON */

dbg_tty_printf(g,2,"entering the main select() loop");

Expand Down

0 comments on commit 5db2345

Please sign in to comment.