-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ciphers #573
Draft
boorad
wants to merge
37
commits into
main
Choose a base branch
from
feat/add-ciphers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: add ciphers #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanmav
reviewed
Jan 9, 2025
packages/react-native-quick-crypto/nitrogen/generated/shared/c++/NamedCurve.hpp
Outdated
Show resolved
Hide resolved
renanmav
reviewed
Jan 9, 2025
8b04a74
to
c69956f
Compare
renanmav
reviewed
Jan 15, 2025
071a068
to
81ccd11
Compare
renanmav
reviewed
Jan 26, 2025
renanmav
reviewed
Jan 26, 2025
algorithm, | ||
key, | ||
iv, | ||
options as Record<string, TransformOptions>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this casting safe?
I see the argument is of type TransformOptions
, and this is casting it to an object of TransformOptions
81ccd11
to
00b2d7a
Compare
renanmav
reviewed
Jan 29, 2025
renanmav
reviewed
Feb 1, 2025
ae7673f
to
6b86ac9
Compare
renanmav
reviewed
Feb 9, 2025
renanmav
reviewed
Feb 11, 2025
renanmav
reviewed
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Ciphers functionality