Skip to content

Commit

Permalink
Verify enums are up-to-date (closes #278)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcwrobel committed Jan 7, 2023
1 parent 626d3b0 commit d318bc3
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 10 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
- Add [Bank Holiday for the Coronation of King Charles III](https://www.timeanddate.com/holidays/uk/king-coronation-day-holiday)
to LONDON calendar (#266).
- Move Croatia (HR) from kuna currency (HKR) countries to euro currency (EUR) countries (#256).
- Verify enums are up-to-date (#278).

### Fixed

Expand Down
24 changes: 16 additions & 8 deletions src/main/java/fr/marcwrobel/jbanking/Agreement.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ public enum Agreement {
* Association.
*
* <p>
* Note that Switzerland, which is not officially a member of the European Economic Area (EEA), is
* also listed because it signed treaties that contain largely
* <a href="https://en.wikipedia.org/wiki/Switzerland%E2%80%93European_Union_relations">the same
* content as the EEA treaties</a>.
*
* <p>
* Last verification date of this list can be seen in the {@code @LastVerification} value.
*
* @see <a href=
Expand All @@ -30,9 +36,11 @@ public enum Agreement {
* @see <a href="https://wikipedia.org/wiki/European_Economic_Area">Wikipedia - European Economic Area</a>
* @since 2.1.0
*/
@LastVerification("2022-10-22")
@LastVerification("2023-01-07")
EUROPEAN_ECONOMIC_AREA(AT, BE, BG, HR, CY, CZ, DK, EE, FI, FR, DE, GR, HU, IS, IE, IT, LV, LI, LT, LU, MT, NL, NO,
PL, PT, RO, SK, SI, ES, SE, CH),
PL, PT, RO, SK, SI, ES, SE,
// see https://en.wikipedia.org/wiki/Switzerland%E2%80%93European_Union_relations#Treaties
CH),

/**
* The European Free Trade Association (EFTA) is a regional trade organization and free trade area. The organization operates
Expand All @@ -46,7 +54,7 @@ public enum Agreement {
* @see <a href="https://wikipedia.org/wiki/European_Free_Trade_Association">Wikipedia - European Free Trade Association</a>
* @since 2.1.0
*/
@LastVerification("2022-10-22")
@LastVerification("2023-01-07")
EUROPEAN_FREE_TRADE_ASSOCIATION(IS, LI, NO, CH),

/**
Expand All @@ -67,7 +75,7 @@ public enum Agreement {
* member state territories and the European Union</a>
* @since 2.1.0
*/
@LastVerification("2022-10-22")
@LastVerification("2023-01-07")
EUROPEAN_UNION(AT, BE, BG, HR, CY, CZ, DK, EE, FI, FR, DE, GR, HU, IE, IT, LV, LT, LU, MT, NL, PL, PT, RO, SK, SI,
ES, SE),

Expand All @@ -84,7 +92,7 @@ public enum Agreement {
* @see <a href="https://wikipedia.org/wiki/Single_Euro_Payments_Area">Wikipedia</a>
* @since 2.1.0
*/
@LastVerification("2022-10-27")
@LastVerification("2023-01-07")
SEPA_COM_PACIFIQUE(PF, NC, WF),

/**
Expand All @@ -95,13 +103,13 @@ public enum Agreement {
* <p>
* Last verification date of this list can be seen in the {@code @LastVerification} value.
*
* @see <a href="https://www.europeanpaymentscouncil.eu/document-library/other/epc-list-sepa-scheme-countries">EPC409-09 EPC
* List of SEPA Countries v4.0 - February 2021</a>
* @see <a href="https://www.europeanpaymentscouncil.eu/document-library/other/epc-list-sepa-scheme-countries">EPC List of
* SEPA Scheme Countries</a>
* @see <a href="https://www.iso13616.org/">IBAN registry</a>
* @see <a href="https://wikipedia.org/wiki/Single_Euro_Payments_Area">Wikipedia</a>
* @since 2.1.0
*/
@LastVerification("2022-10-22")
@LastVerification("2023-01-07")
SINGLE_EURO_PAYMENTS_AREA(
// EU countries
AT, BE, BG, HR, CY, CZ, DK, EE, FI, FR, DE, GR, HU, IE, IT, LV, LT, LU, MT, NL, PL, PT, RO, SK, SI, ES, SE,
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/fr/marcwrobel/jbanking/IsoCountry.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
* @see <a href="https://www.iso.org/iso-3166-country-codes.html">ISO 3166 Country Codes</a>
* @since 1.0
*/
@LastVerification("2022-10-22")
@LastVerification("2023-01-07")
public enum IsoCountry {
/**
* Afghanistan (aka the Islamic Republic of Afghanistan).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* @see <a href="https://bank-code.net/iban/country-list">List of Countries using the IBAN standard</a>
* @since 1.0
*/
@LastVerification("2022-10-22")
@LastVerification("2023-01-07")
@SuppressWarnings("java:S1192") // swift expressions cannot be constants (maintainability).
public enum BbanStructure {
/**
Expand Down

0 comments on commit d318bc3

Please sign in to comment.