Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update datahandler.py #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update datahandler.py #11

wants to merge 1 commit into from

Conversation

judicaelclair
Copy link

Fix to close connection when multi-account detected

@asew
Update datahandler.py
fef9ab4 
Fix to close connection when multi-account detected
@marcusmoller
Copy link
Owner

Cheers. I appreciate the fixes, but could you leave out the comments saying fixed by etc. If you're worried about getting credits for your code, don't be. You'll show up in the commit history.

The problem with the comments is that eventually the code would just end up with a crazy amount of fixed by-comments if all did the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@judicaelclair @marcusmoller @asew