Code improvement and feature additions #123
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Restructured code to use namespaces better 2. Fixed ignored Test cases and renamed other according to Java spec 3. Improved code coverage 4. Fixed code (missing synchronization on date provider, incorrect get first customer name function and etc) 5. Introduced enum for account type 6. Introduced BusinessException hierarchy and added boundary scenario test cases for them. 7. Added new feature and test coverage to transfer between two accounts for customer.
1. Added feature to accrue daily based on compound rate 2. Added unit tests to cover different scenarios for above feature 3. Some additional clean up and comments indication to accrue on 365 days basis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High level summary:
Please note following feature was not added: Maxi-Savings accounts* to have an
interest rate of 5% assuming no withdrawals in the past 10 days otherwise 0.1%.