Add missing excplicit property modifiers

marcoroth · Feb 13, 2024 · 0e4a911 · 0e4a911
1 parent 7c4b292
commit 0e4a911
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 5 deletions.
diff --git a/src/controller_definition.ts b/src/controller_definition.ts
@@ -15,8 +15,8 @@ export class ControllerDefinition {
   readonly project: Project
   readonly classDeclaration: ClassDeclaration
 
-  isTyped: boolean = false
-  anyDecorator: boolean = false
+  public isTyped: boolean = false
+  public anyDecorator: boolean = false
 
   readonly errors: ParseError[] = []
   readonly methods: Array<MethodDefinition> = []

diff --git a/src/parser.ts b/src/parser.ts
@@ -4,9 +4,6 @@ import { Project } from "./project"
 
 import type { ParserOptions } from "./types"
 
-// TODO: Support decorator + reflect-metadata value definitions
-// TODO: error or multiple classes
-
 export class Parser {
   readonly project: Project
 

diff --git a/src/project.ts b/src/project.ts
@@ -13,6 +13,7 @@ import type { NodeModule } from "./types"
 export class Project {
   readonly projectPath: string
   readonly controllerRootFallback = "app/javascript/controllers"
+
   static readonly javascriptExtensions = ["js", "mjs", "cjs", "jsx"]
   static readonly typescriptExtensions = ["ts", "mts", "tsx"]
 

diff --git a/src/util/decorators.ts b/src/util/decorators.ts
@@ -69,6 +69,7 @@ export function parseValueDecorator(controllerDefinition: ControllerDefinition,
   const hasOneArgument = (decorator.expression.type === "CallExpression" && decorator.expression.arguments.length === 1)
 
   if (isIdentifier || !hasOneArgument) {
+    // TODO: Support decorator + reflect-metadata value definitions
     throw new Error("We dont support reflected types yet")
   }