Move to more variables

[jthoel]

Allows for more customization without having to rebuild the image and change the file.

[marcopaganini]

Where do these variables come from? Where is "CONTEXT_PATH" defined, for example?

[jthoel]

They get passed during the docker runtime. For example, when I made the changes to my local copy, I was able to run the following to pass the URL change and change the memory. Adding the http port and https port lets users do some more customization

docker run -d -p 4040:4040 \
 -v /var/lib/docker/volumes/subsonic/data:/var/subsonic \
 -v /mnt/music/:/music \
 -v /mnt/audiobooks/:/audiobooks \
 -e MAX_MEM=1024 \
 -e CONTEXT_PATH=/subsonic \
 --name=subsonic mpaganini/alpine-subsonic:latest

[marcopaganini]

Yes, but then we need to run the docker run with specific commands or things will fail. Ideally, we would be able to override those, but it should run with sane defaults if not specified.

[HewittJC]

What if we just posted a docker-compose along side this as well. I'd be willing to add mine as a PR

To your point about things having to be set, you already have to set things or it wont work (i.e. volumes)

To give some context to why this would be good, I have a setup with a NextCloud server running in Docker along side the subsonic server. I would like to be able to mount things from my NextCloud into Subsonic. I currently have this working but until I rebuild the container so that the UID's match for the subsonic user and the www-data user in NextCloud, I have to do a strange permissions dance with every change to the files

[marcopaganini]

I grant the point that we already have to pass something to docker run (for the volume).

Another option would be to keep the ENV statements with sane default. This way, users can override only what they want with the docker run -e var=value command.

For example, users won't typically have to override HTTPS_PORT. We could do ENV HTTPS_PORT=443 inside the file. This would allow most users to just use docker run with the regular parameters without worrying about defining this port. If they need to redefine HTTPS_PORT, all they need to do is run docker run -e HTTPS_PORT=443 ... and we're set.

Does it make sense?

[HewittJC]

Yea I think this is fair 👍 👌

[marcopaganini]

Now that we define these three environment variables based on other variables, we have two choices:

1. Define default HTTPS_PORT, CONTEXT_PATH, and MAX_MEM with an ENV in the Dockerfile, so we don't have to type them when using docker run.

2. Define defaults here, like:

SUBSONIC_HTTPS_PORT=${HTTPS_PORT:-0}
SUBSONIC_CONTEXT_PATH=${CONTEXT_PATH:-/}
SUBSONIC_MAX_MEMORY=${MAX_MEM:-200}

This would use shell constructs to set defaults if those variables are not set.

I'm OK with either. Just pick one of the two methods above (and if you have a few minutes to spare, run a quick test to make sure it works as expected). :)