Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop find as soon as match is discovered #147

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

wlewis-formative
Copy link

Changes

  • Modifies find to stop as soon as a match is discovered, and not on the next loop iteration. I think this preserves the current behavior, but I might be missing some subtlety here. At least all of the existing tests pass.
  • Replaces ignoreProcessEnv: true with processEnv: {} in loadDotenv. Looks like this was removed from dotenv-expand.

William Lewis added 2 commits April 17, 2024 08:47
Looks like the `ignoreProcessEnv` option was [removed](https://github.com/motdotla/dotenv-expand/blob/master/CHANGELOG.md#removed) from `dotenv-expand`.
Modifies `find` to stop as soon as a match is found, and not on the next loop
iteration.
@wlewis-formative wlewis-formative changed the title Fix/146 Stop find as soon as match is discovered Apr 17, 2024
@marcocesarato marcocesarato merged commit e7a6670 into marcocesarato:master Apr 17, 2024
0 of 4 checks passed
@wlewis-formative wlewis-formative deleted the fix/146 branch April 18, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants