Bug 1834519 - Don't throw when popovers/dialogs are in requested stat…

…e. r=emilio Update to be in line with spec discussions at whatwg/html#9142 Differential Revision: https://phabricator.services.mozilla.com/D178782 UltraBlame original commit: 39007d3d4f3eee8382115fb59e595de006ceca70
marco-c · May 31, 2023 · d198a18 · d198a18
1 parent cd71c63
commit d198a18
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 42 deletions.
diff --git a/dom/html/HTMLDialogElement.cpp b/dom/html/HTMLDialogElement.cpp
@@ -538,9 +538,38 @@ Open
 )
 )
 {
+if
+(
+!
+IsInTopLayer
+(
+)
+)
+{
 return
 ;
 }
+return
+aError
+.
+ThrowInvalidStateError
+(
+"
+Cannot
+call
+show
+(
+)
+on
+an
+open
+modal
+dialog
+.
+"
+)
+;
+}
 if
 (
 IsPopoverOpen
@@ -758,30 +787,48 @@ aError
 {
 if
 (
-!
-IsInComposedDoc
+Open
+(
+)
+)
+{
+if
+(
+IsInTopLayer
 (
 )
 )
 {
 return
+;
+}
+return
 aError
 .
 ThrowInvalidStateError
 (
 "
-Dialog
-element
-is
-not
-connected
+Cannot
+call
+showModal
+(
+)
+on
+an
+open
+non
+-
+modal
+dialog
+.
 "
 )
 ;
 }
 if
 (
-Open
+!
+IsInComposedDoc
 (
 )
 )
@@ -794,13 +841,9 @@ ThrowInvalidStateError
 "
 Dialog
 element
-already
-has
-an
-'
-open
-'
-attribute
+is
+not
+connected
 "
 )
 ;

diff --git a/...emantics/interactive-elements/the-dialog-element/dialog-no-throw-requested-state.html.ini b/...emantics/interactive-elements/the-dialog-element/dialog-no-throw-requested-state.html.ini