Bug 1916260 - Part 9: Resolve binding in destructuring before retriev…

…ing destructured element. r=arai

`BytecodeEmitter::emitDestructuringLHSRef` needs to call `NameOpEmitter::prepareForRhs`
to emit the necessary steps to resolve environment bindings. To avoid adding a new
`skipPrepareForRhs` method to `NameOpEmitter`, instead pass `DestructuringLHSRef&`
to `emitDestructuringLHSRef`, where `DestructuringLHSRef` holds the emitter for the
destructuring left-hand side reference.

Tests are in <tc39/test262#4216>.

Differential Revision: https://phabricator.services.mozilla.com/D220828

UltraBlame original commit: 5a9e48dab16e9706ff963d6155df153acb6a0354

js/src/frontend/BytecodeEmitter.h

@@ -574,6 +574,9 @@ class
 ClassEmitter
 ;
 class
+DestructuringLHSRef
+;
+class
 ElemOpEmitter
 ;
 class
@@ -5968,22 +5971,6 @@ it
 emits
 nothing
 .
-/
-/
-|
-emitted
-|
-parameter
-receives
-the
-number
-of
-values
-pushed
-onto
-the
-stack
-.
 [
 [
 nodiscard
@@ -5995,9 +5982,11 @@ emitDestructuringLHSRef
 ParseNode
 *
 target
-size_t
-*
-emitted
+DestructuringFlavor
+flav
+DestructuringLHSRef
+&
+lref
 )
 ;
 /
@@ -6068,6 +6057,9 @@ ParseNode
 target
 DestructuringFlavor
 flav
+DestructuringLHSRef
+&
+lref
 )
 ;
 /

js/src/frontend/ElemOpEmitter.cpp

@@ -892,53 +892,6 @@ bool
 ElemOpEmitter
 :
 :
-skipObjAndKeyAndRhs
-(
-)
-{
-MOZ_ASSERT
-(
-state_
-=
-=
-State
-:
-:
-Start
-)
-;
-MOZ_ASSERT
-(
-isSimpleAssignment
-(
-)
-|
-|
-isPropInit
-(
-)
-)
-;
-#
-ifdef
-DEBUG
-state_
-=
-State
-:
-:
-Rhs
-;
-#
-endif
-return
-true
-;
-}
-bool
-ElemOpEmitter
-:
-:
 emitDelete
 (
 )